refactor baseUrl to fix exposing NEXT_PUBLIC_VERCEL_URL #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prod URL (TWITTER_SITE)
|
@valiant1x is attempting to deploy a commit to the Vercel Solutions Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leerob
reviewed
Jul 29, 2024
| @@ -29,3 +29,10 @@ export const TAGS = { | |||
| export const HIDDEN_PRODUCT_TAG = 'nextjs-frontend-hidden'; | |||
| export const DEFAULT_OPTION = 'Default Title'; | |||
| export const SHOPIFY_GRAPHQL_API_ENDPOINT = '/api/2023-01/graphql.json'; | |||
|
|
|||
| export const BASE_URL = | |||
There was a problem hiding this comment.
I think we should be able to use VERCEL_PROJECT_PRODUCTION_URL here now.
There was a problem hiding this comment.
Bump on this! Are you still interested in taking this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://my-cool-name-h2134yh2-github-user-projects.vercel.app/. this ends up in robots.txt, sitemap, and the opengraph image URLs as part of the current app configuration, assuming you deploy with VercelTWITTER_SITE)fixes #1324